fix dockerfile definitions. #12424
Open
fix dockerfile definitions. #12424
+136
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DN6 could you give this a quick check if the changes are alright? I have also gone ahead and included the "test" related installations in the Dockerfiles themselves so that we don't have install them during CI (those changes will come in a separate PR). |
DN6
approved these changes
Oct 3, 2025
| torchaudio \ | ||
| --extra-index-url https://download.pytorch.org/whl/cpu | ||
|
|
||
| RUN uv pip install --no-cache-dir "git+https://github.com/huggingface/diffusers.git@main#egg=diffusers[test]" |
There was a problem hiding this comment.
Is this needed? We already install test deps in the workflow file?
There was a problem hiding this comment.
Yeah so in a future PR (immediately after this one), I will remove that step so that we can save some time skipping those installs.
DN6
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Docker build is broken from the past two days:
https://github.com/huggingface/diffusers/actions/runs/18208988147/job/51845669366#step:5:1173
Only changes the Dockerfiles that we use in
.github/workflows/build_docker_images.yml.