Add support for Jinja for chat model templates #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rocketknight1 I'd be glad if you can review this and consider merging it :) |
|
This looks like it's using huggingface/jinja, so cc @xenova, but feel free to ask me if you want me to comment on any of the higher-level chat template stuff! |
|
Thanks for the PR! I'll be testing it locally to make sure everything works but looks good like this 😄 |
|
@nsarrazin Great! 🙌 |
|
Thanks for the contribution! 😄 |
maksym-work
pushed a commit
to siilats/chat-ui
that referenced
this pull request
Jul 2, 2025
* Add support for Jinja for chat model templates * feat(docs): improve docs regarding templates --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* Add support for Jinja for chat model templates * feat(docs): improve docs regarding templates --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* Add support for Jinja for chat model templates * feat(docs): improve docs regarding templates --------- Co-authored-by: Nathan Sarrazin <[email protected]>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* Add support for Jinja for chat model templates * feat(docs): improve docs regarding templates --------- Co-authored-by: Nathan Sarrazin <[email protected]>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* Add support for Jinja for chat model templates * feat(docs): improve docs regarding templates --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue for why people may want this:
#1525