-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: migrating ScrollToBottomBtn to svelte-5 #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrating ScrollToBottomBtn to svelte-5 #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for the contrib! 🚀
I tried to run this locally but i'm getting the following error
Uncaught Svelte error: effect_update_depth_exceeded
Maximum update depth exceeded. This can happen when a reactive block or effect repeatedly sets a new value. Svelte limits the number of nested updates to prevent infinite loops
Last ten effects were:
Array(10) [ ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn(), ScrollToBottomBtn() ]
I think there's something going on with the reactivity there, do you also get this locally? 👀
Sorry for that! I would like to double check but, I'm no longer able to run it locally:
It is something related to my HF token? Sorry for the fuzz! |
If you're using the production huggingchat config, some models require that you accept some terms on the Hugging Face Hub. For example: https://huggingface.co/mistralai/Mistral-Nemo-Instruct-2407/ should show near the top. I think there's a few more, there should be some warnings in the logs. Otherwise feel free to remove some models from the config for testing 😄 |
Thanks for your patience, I think I've found the problem with my previous implementation. I'm sorry, even a bit ashamed, because for some reason I was redirected to the chat... in production during my development! 🤦 However, I'm having a problem with the proxy right now.
It's not a big deal, since I created some fake messages to test the ScrollToBottom component 😉 |
Ooh yeah the prod config has been updated recently to use an internal proxy, my bad I forgot to update the docs! |
Alright I've updated Will review the PR now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great thanks a lot! 🚀
* refactor: migrating ScrollToBottomBtn to svelte-5 * fix: infinite loop on the scrolltobottom effect --------- Co-authored-by: Nathan Sarrazin <[email protected]>
* refactor: migrating ScrollToBottomBtn to svelte-5 * fix: infinite loop on the scrolltobottom effect --------- Co-authored-by: Nathan Sarrazin <[email protected]>
* refactor: migrating ScrollToBottomBtn to svelte-5 * fix: infinite loop on the scrolltobottom effect --------- Co-authored-by: Nathan Sarrazin <[email protected]>
* refactor: migrating ScrollToBottomBtn to svelte-5 * fix: infinite loop on the scrolltobottom effect --------- Co-authored-by: Nathan Sarrazin <[email protected]>
* refactor: migrating ScrollToBottomBtn to svelte-5 * fix: infinite loop on the scrolltobottom effect --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Hi @nsarrazin!
I'm trying to refactor this component with the most minimalist way possible!
I hope the CI will be good too 🤞
Following #1691