Skip to content

Conversation

tarekbecker
Copy link
Contributor

This pull requests adds support for Amazon Nova models. The API is slightly different. No need to specify the type etc: https://docs.aws.amazon.com/nova/latest/userguide/complete-request-schema.html

In addition, it fixes the hard coded "image/jpeg" to use the mime type from the file processor.

@nsarrazin nsarrazin self-requested a review December 19, 2024 13:05
@nsarrazin nsarrazin self-assigned this Dec 19, 2024
@nsarrazin
Copy link
Contributor

nsarrazin commented Jan 2, 2025

Hi! Thanks for the contribution. I took the liberty of removing some console.log that were left in the PR. I've also replaced the implicit check to see if model.id contains nova with a more explicit isNova flag.

Let me know if those changes still work for you and if so LGTM! 🚀

@tarekbecker
Copy link
Contributor Author

LGTM. Thanks for the fixes.

@nsarrazin nsarrazin merged commit e6dc3de into huggingface:main Jan 2, 2025
3 checks passed
maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
* Add support for Amazon Nova

* fix linting issue

* fix: replace model.id check with `isNova` flag and remove debug logs

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
* Add support for Amazon Nova

* fix linting issue

* fix: replace model.id check with `isNova` flag and remove debug logs

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
* Add support for Amazon Nova

* fix linting issue

* fix: replace model.id check with `isNova` flag and remove debug logs

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
* Add support for Amazon Nova

* fix linting issue

* fix: replace model.id check with `isNova` flag and remove debug logs

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
* Add support for Amazon Nova

* fix linting issue

* fix: replace model.id check with `isNova` flag and remove debug logs

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants