Skip to content

Conversation

coliff
Copy link
Member

@coliff coliff commented Sep 11, 2025

  • Lowered the minimum Node.js engine requirement to 18 in package.json and added Node.js 18 to the test matrix.
  • Updated CodeQL GitHub Actions to v3.30.2 and improved documentation for GitHub Actions usage.
  • Removed a test that checked for rule presence in rules/index.mdx. (because we don't put rules live on the website until new version is published).

@coliff coliff requested a review from Copilot September 11, 2025 01:59
@github-actions github-actions bot added documentation dependencies Pull requests that update a dependency file test labels Sep 11, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Node.js compatibility and GitHub Actions configurations while improving test coverage practices. The changes lower the minimum Node.js version requirement from 20 to 18, update CodeQL analysis actions to a newer version, and remove a test that was checking for rule presence on the website before publication.

Key changes:

  • Lower Node.js engine requirement to version 18 and add Node 18 to CI test matrix
  • Update CodeQL GitHub Actions from v3.30.1 to v3.30.2
  • Remove test checking for rule presence in rules/index.mdx to align with publication workflow

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated Node.js engine requirement from >=20 to >=18
.github/workflows/test.yml Added Node.js 18 to the test matrix
.github/workflows/codeql-analysis.yml Updated CodeQL actions from v3.30.1 to v3.30.2
.github/copilot-instructions.md Added GitHub Actions documentation and improved formatting
test/rules/documentation.spec.js Removed test checking for rule presence in rules/index.mdx

Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2025

Deploying htmlhint with  Cloudflare Pages  Cloudflare Pages

Latest commit: abc6090
Status: ✅  Deploy successful!
Preview URL: https://de129e9e.htmlhint.pages.dev
Branch Preview URL: https://dev-coliff-add-back-node18-s.htmlhint.pages.dev

View logs

gemini-code-assist[bot]

This comment was marked as resolved.

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (95e6a13) to head (abc6090).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1719      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422aa48...abc6090. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lowered the minimum Node.js engine requirement to 18 in package.json and added Node.js 18 to the test matrix. Updated CodeQL GitHub Actions to v3.30.2 and improved documentation for GitHub Actions usage. Removed a test that checked for rule presence in rules/index.mdx.

Update website.yml

Update project rules and labeler workflow formatting

Expanded general project rules to include line endings, code formatting, rule ordering, and GitHub Actions best practices. Also standardized comment spacing in the labeler workflow permissions section.
@coliff coliff force-pushed the dev/coliff/add-back-node18-support branch from 7795d77 to abc6090 Compare September 11, 2025 02:08
@coliff coliff merged commit 294d58f into main Sep 11, 2025
30 checks passed
@coliff coliff deleted the dev/coliff/add-back-node18-support branch September 11, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant