feat: add config option to control initial buffer in buffer picker #14474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoloEdits
force-pushed
the
buffer-picker-config
branch
from
be884cd to
9b962e4
Compare
|
Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config option that controls the behavior added in #14176.
It does this by adding an
editor.buffer-pickersection to the config, and with itsstart-positionoption, accepts two values of eithercurrentor, the default, matching the new behavior change,previous.This is something that I just couldn't get used to even after a week, and others may feel the same.
Although the behavior PR was merged, with this now configurable, it could warrant some discussion around if it should be the default or not, given the change some may feel is unintuitive.
Closes #14472