Improving tokenizer performance by initialising input array beforehand #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tokenizer
function was computing the length of the input on the fly i.e.for current < len([]rune(input))
. While it's not that big of a deal, it forces the compiler to re-compute the array for each iteration of the loop. Instead, what I did was that I calculated the array beforehand and then passed it to the loop as well as the line that required thecurrent
character in theinput
.