Fix theme preference not being restored correctly #125
Conversation
Using `set_visuals(Visuals::dark())` in `main()` somehow interfered badly with the theme switching code such that a light theme was not restored properly. Instead, the correct function to set the theme on startup is `set_theme()` and we should pass in the saved perference instead of hard-coding dark-mode. With these changes, all of the theme preferences work correctly and are restored correctly.
|
Hi, thanks a lot for fixing this! Can you add an entry to the changelog? :) |
|
Done! :) I held off from adding a changelog entry to the other PRs for now, to not create a million merge conflicts. |
|
And just wanted to say, very cool project! Been using this tool to hack together a quick temperature sensor for monitoring tiny temperature drifts: https://wiki.fa-fo.de/_detail/projects:stm:2025-08-24_04-34-temperature-stm.png?id=projects%3Astm%3Alog |
Very cool! Thanks for showing me and thank you very, very much for the contributions! Much appreciated, don't bother about the changelog, I'll add the entries there :-) |
Hi,
I noticed that the theme preference is not being restored correctly. This PR contains the necessary changes to make it work :)
Using
set_visuals(Visuals::dark())inmain()somehow interfered badly with the theme switching code such that a light theme was not restored properly.Instead, the correct function to set the theme on startup is
set_theme()and we should pass in the saved preference instead of hard-coding dark-mode.