Skip to content

inspect: improve typings for toJSON call #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021
Merged

inspect: improve typings for toJSON call #2938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/jsutils/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ function formatValue(value: mixed, seenValues: Array<mixed>): string {
case 'function':
return value.name ? `[function ${value.name}]` : '[function]';
case 'object':
if (value === null) {
return 'null';
}
return formatObjectValue(value, seenValues);
default:
return String(value);
Expand All @@ -30,14 +27,18 @@ function formatObjectValue(
value: Object,
previouslySeenValues: Array<mixed>,
): string {
if (value === null) {
return 'null';
}

if (previouslySeenValues.indexOf(value) !== -1) {
return '[Circular]';
}

const seenValues = [...previouslySeenValues, value];

if (typeof value.toJSON === 'function') {
const jsonValue = value.toJSON(value);
const jsonValue = (value.toJSON: () => mixed)();

// check for infinite recursion
if (jsonValue !== value) {
Expand Down