Skip to content

Add Base64 scalar #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Add Base64 scalar #1221

merged 1 commit into from
Jul 2, 2020

Conversation

EpicEric
Copy link
Contributor

@EpicEric EpicEric commented Jul 1, 2020

No description provided.

jkimbo
jkimbo requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks @EpicEric ! Added a couple of minor comments.

@jkimbo jkimbo self-requested a review July 2, 2020 14:47
jkimbo
jkimbo approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@syrusakbary syrusakbary merged commit c61f0f7 into graphql-python:master Jul 2, 2020
@EpicEric EpicEric deleted the base64 branch July 2, 2020 17:56
@jkimbo jkimbo mentioned this pull request Jul 3, 2020
Merged
@simonw simonw mentioned this pull request Aug 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@jkimbo jkimbo jkimbo approved these changes

@ekampf ekampf Awaiting requested review from ekampf

@mvanlonden mvanlonden Awaiting requested review from mvanlonden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EpicEric @syrusakbary @jkimbo