fix: go-playground-upload not working in playground snippet buffers #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the condition in the go-playground-upload function, so it runs go-play-buffer within go-playground snippet file buffers only. Previously it would run it in any buffer, except snippet buffers. I also removed the cursor movement and insertion of the result from go-play-upload, as default behavior of go-play-buffer and go-play-region is to place the URL on the killring, and can be customized setting the go-play-browse-function variable.
grafov
approved these changes
Nov 26, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the condition in the go-playground-upload function, so it
runs go-play-buffer within go-playground snippet file buffers only.
Previously it would run it in any buffer, except snippet buffers.
I also removed the cursor movement and insertion of the result from
go-play-upload, as default behavior of go-play-buffer and go-play-region
is to place the URL on the killring, and can be customized setting the
go-play-browse-function variable.