Fix a bug where starting a playground would change current directory #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting a new playground, before executing the playground initialistaion command, the current directory would be changed to the snippet directory. This would have the side-effect of setting the current directory of whatever buffer the user was in previously, which could cause unexpected behaviour with other commands. Instead of changing directory, locally bind default-directory so that the initialisation command will be executed from the snippet directory without an side effects.
|
Please accept this it's very annoying :) |
|
@grafov Could you merge this PR? |
|
It is better late than never :| Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a new playground, before executing the playground
initialistaion command, the current directory would be changed to the
snippet directory. This would have the side-effect of setting the
current directory of whatever buffer the user was in previously, which
could cause unexpected behaviour with other commands.
Instead of changing directory, locally bind default-directory so that
the initialisation command will be executed from the snippet directory
without an side effects.