Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Conversation

s-starostin
Copy link
Contributor

No description provided.

@FinnHuelsbusch
Copy link

@trotttrotttrott Is there a reason this PR wasn't viewed/merged yet?

@dclendenan
Copy link

dclendenan commented Jan 28, 2021

FWIW we are using this change in production (thanks @s-starostin)

@roidelapluie
Copy link
Collaborator

hello,

thanks for this. I would inline newTransformation. Why is that a new file?

@s-starostin
Copy link
Contributor Author

hello,

thanks for this. I would inline newTransformation. Why is that a new file?

Hello, can't understand you. Could you explain what you mean, please?

@roidelapluie
Copy link
Collaborator

yes:

transformation.libsonnet

That file does not seem needed, we could do everything in table.libsonnet.

@s-starostin
Copy link
Contributor Author

But transformations can be applied not only for tables, but for other entities too (stat panels, for example).
I can't imagine a real case on applying those for other types now. For tables the case is clear and this is a really useful feature.

@dclendenan
Copy link

I think that making it inline within table would clutter that file, especially if the transformation object evolves to be more complex. The new file seems a better design option to me.

@roidelapluie roidelapluie merged commit 9287885 into grafana:master Jan 28, 2021
@roidelapluie
Copy link
Collaborator

roidelapluie commented Jan 28, 2021

thanks, the reasoning makes sense!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants