[GR-69454] Reduce JVMCI annotation API to accessing raw class file bytes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graalvmbot
force-pushed
the
ds/GR-69454
branch
from
540b083 to
9a4d63b
Compare
graalvmbot
force-pushed
the
ds/GR-69454
branch
from
9a4d63b to
451ff7b
Compare
graalvmbot
force-pushed
the
ds/GR-69454
branch
from
451ff7b to
24b7bc0
Compare
zapster
approved these changes
Oct 1, 2025
| * record components of this record class, or {@code null} if this class is | ||
| * not a record class. | ||
| */ | ||
| ResolvedJavaRecordComponent[] getRecordComponents(); |
There was a problem hiding this comment.
We should decide whether we want to go for arrays or unmodifiable lists.
There was a problem hiding this comment.
Right. Since this is new API and we don't need to worry about backward compatibility, we should go for an unmodifiable list.
graalvmbot
force-pushed
the
ds/GR-69454
branch
from
24b7bc0 to
45dba90
Compare
…ded ResolvedJavaRecordComponent
graalvmbot
force-pushed
the
ds/GR-69454
branch
from
45dba90 to
faecb26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the JVMCI part of oracle/graal#12224:
jdk.vm.ci.meta.AnnotationData.jdk.vm.ci.meta.ResolvedJavaRecordComponent(JVMCI analog ofjava.lang.reflect.RecordComponent).jdk.vm.ci.meta.Annotatedtojdk.vm.ci.meta.annotation.Annotatedand converted it to expose class file annotation bytes instead of the result of parsing these bytes.Other smaller changes:
HotSpotMetaAccessProvider.lookupFieldfor classes with many fields. See here for motivation.JVMCI.getRuntime()).