feat: create db_dtypes JSONDtype and JSONArray #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
tswast
requested changes
Jul 23, 2024
db_dtypes/json.py
Outdated
| @property | ||
| def type(self) -> type[str]: | ||
| """Return the scalar type for the array, e.g. int.""" | ||
| return dict |
There was a problem hiding this comment.
Could this be a Union[dict, list, str, int, float]?
Please create a JSONScalarType = Union[dict, list, str, int, float] module-level variable and use it here, if so.
There was a problem hiding this comment.
I tried JSONScalarType and typing.Any but both of them are hitting errors on pandas source codes. Also, I didn't find an example Extension dtype that has multiple types. For now, I would leave it as a str to indicate its storage type and the type of to_numpy as well. Here are the call stack of both of them:
https://screenshot.googleplex.com/6GiKkNU9T2e8GPm
https://screenshot.googleplex.com/9QfDFsrUzD7PMrT
tswast
reviewed
Jul 23, 2024
tswast
reviewed
Jul 23, 2024
tswast
requested changes
Jul 24, 2024
4 tasks
chelsea-lin
force-pushed
the
main_chelsealin_dbjson
branch
from
5b8f379 to
9e92dc7
Compare
4 tasks
tswast
reviewed
Aug 6, 2024
chelsea-lin
force-pushed
the
main_chelsealin_dbjson
branch
from
cebde95 to
efe72cc
Compare
chelsea-lin
force-pushed
the
main_chelsealin_dbjson
branch
3 times, most recently
from
865f93b to
790f257
Compare
tswast
reviewed
Aug 6, 2024
chelsea-lin
force-pushed
the
main_chelsealin_dbjson
branch
2 times, most recently
from
98debff to
b4cfcd9
Compare
tswast
reviewed
Aug 8, 2024
tswast
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal bug b/312728178 🦕