Skip to content

feat: implement std.equalsIgnoreCase #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2023
Merged

feat: implement std.equalsIgnoreCase #1079

merged 2 commits into from
May 25, 2023

Conversation

rohitjangid
Copy link
Member

@rohitjangid rohitjangid commented May 3, 2023 •
edited
Loading

Implement std.equalsIgnoreCase in standard library

go-jsonnet PR: google/go-jsonnet#692

@rohitjangid rohitjangid mentioned this pull request May 3, 2023
Merged
@sparkprime
Copy link
Contributor

This should be std.equalsIgnoreCase() as we already have std.equals (and we don't have std.isEqual)

@rohitjangid rohitjangid force-pushed the feat/string-equal-ignore-case branch from b4f542c to 752dd9d Compare May 4, 2023 04:37
@rohitjangid rohitjangid changed the title feat: implement std.isEqualIgnoreCase feat: implement std.equalsIgnoreCase May 4, 2023
@rohitjangid
Copy link
Member Author

@sparkprime renamed it to equalsIgnoreCase

@rohitjangid rohitjangid force-pushed the feat/string-equal-ignore-case branch from 752dd9d to 4025b1d Compare May 8, 2023 04:33
@sparkprime sparkprime merged commit b42d8ec into google:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitjangid @sparkprime