dev: simplify sort results processors #5150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
topic: cleanup
ldez
force-pushed
the
feat/sort-results
branch
from
d133836 to
dcc0ff2
Compare
ldez
force-pushed
the
feat/sort-results
branch
2 times, most recently
from
ede25e5 to
18da1e1
Compare
ldez
force-pushed
the
feat/sort-results
branch
from
18da1e1 to
ceb50e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
cmphas been added in go1.21 + the usage of standard comparison values -> it allows theSortResultsprocessor to be simplified.259 LOC to 148 LOC 🎉
And a way less complex than before.