govet: add a warning about the deprecation of check-shadowing #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/deprecate-govet-check-shadowing
branch
from
5afab67 to
5d625d7
Compare
Antonboom
approved these changes
Mar 19, 2024
|
We can track usages in the wild:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was "unofficially" deprecated since v1.19 (2019) (inside #697).
https://github.com/golangci/golangci-lint/pull/697/files#diff-5144159bbaf9571c0fb12b9077a23f5dd046eda75d10c4d02c8317d071b54019R124
I think it's time to add a warning to deprecate it.
The deprecation message is complex because there are several possible configurations:
check-shadowing+enable-allcheck-shadowing+disable-allcheck-shadowing+enablecheck-shadowing+disable