Skip to content

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 18, 2024

Runs all golangci-lint commands.

The command run is tested by the other steps (make test).

To avoid problem similar to #3567

@ldez ldez added enhancement New feature or improvement area: ci PR that update CI labels Mar 18, 2024
@ldez ldez added this to the next milestone Mar 18, 2024
@ldez ldez requested review from alexandear and bombsimon March 18, 2024 00:27
@ldez ldez added area: tests Continuous integration, tests and other checks area: CLI Related to CLI labels Mar 18, 2024
Copy link
Contributor

@Antonboom Antonboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# Note: the command `run` is tested by the previous steps (`make test`).
commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to not forget to update this :D

maybe we need bash magic like

  1. run golangci-lint 42
  2. parse Available Commands:
  3. loop: run command from 2, parse Available Commands again
  4. etc

But, of course, explicit is better than implicit 🤷‍♂️

@ldez ldez merged commit b91c194 into golangci:master Mar 18, 2024
@ldez ldez deleted the feat/ci-run-all-commands branch March 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI area: CLI Related to CLI area: tests Continuous integration, tests and other checks enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants