--new-from-rev stopped working from version 1.51.1

[man0xff]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've read the typecheck section of the FAQ (https://golangci-lint.run/usage/faq/#why-do-you-have-typecheck-errors).
• Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

With versions higher than 1.51.0 I'm getting errors running that command:

docker run --rm -v $(pwd):/x -w /x golangci/golangci-lint:<version> golangci-lint run --new-from-rev HEAD

Version 1.51.0 doesn't show any error as expected.

Version of golangci-lint

Tried versions from 1.51.0 and higher.

Configuration

Default configuration.

Go environment

Running from docker.

Verbose output of running

Don't use cache while running the docker image.

Code example or link to a public repository

Validation

• Yes, I've included all information above (version, config, etc.).

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

Hello,

can you provide "Verbose output of running"?

[ldez]

$ docker run --rm -v $(pwd):/x -w /x golangci/golangci-lint:v1.53.3 golangci-lint run --new-from-rev HEAD
level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: no version control repository found"

It's not an error but a warning.

It's related to git:

fatal: detected dubious ownership in repository at '/x'
To add an exception for this directory, call:

        git config --global --add safe.directory /x

you have to run git config --global --add safe.directory /x

[man0xff]

Thanks, it works. But it might be worth adding some directory to the safe.directory to the original image if it's so important for the tool to work.