x/tools/gopls/internal/test/integration/diagnostics: TestValidImportCheck_GoPackagesDriver/default#01 failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/diagnostics" && test == "TestValidImportCheck_GoPackagesDriver/default#01"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestValidImportCheck_GoPackagesDriver/default#01
    runner.go:238: context deadline exceeded
#### Start Gopls Test Logs for "TestValidImportCheck_GoPackagesDriver/default#01"
[Trace - 15:34:49.552 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"DRIVERTEST_RUN_AS_DRIVER":"1","GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"/home/swarming/.swarming/w/ir/x/t/go-build2550299547/b871/diagnostics.test","GOPATH":"/home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default#01/gopath","GOPROXY":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default#01/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default%2301/work","name":"work"}]}


[Trace - 15:34:49.946 PM] Received response 'initialize - (1)' in 394ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel f4750a6cfb8ae84acee56cca1a51c886fa16cc32\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/diagnostics.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm\"},{\"Key\":\"GOOS\",\"Value\":\"netbsd\"},{\"Key\":\"GOARM\",\"Value\":\"7\"}],\"Version\":\"(devel)\"}"}}

...
panic: test timed out after 50m0s
	running tests:
		TestValidImportCheck_GoPackagesDriver (21s)
		TestValidImportCheck_GoPackagesDriver/default#01 (7s)

goroutine 56575 [running]:
testing.(*M).startAlarm.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2490 +0x3a4
created by time.goFunc
	/home/swarming/.swarming/w/ir/x/w/goroot/src/time/sleep.go:215 +0x2c
...
fmt.Fprintf({0x10c8ca0, 0x88a5310}, {0xdf327b, 0x18}, {0xbe15e80, 0x3, 0x3})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:226 +0x9c
golang.org/x/tools/gopls/internal/protocol.(*loggingStream).logCommon(0xd3a6708, {0x10c9180, 0x2679aa80}, 0x1)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/gopls/internal/protocol/log.go:117 +0x828
golang.org/x/tools/gopls/internal/protocol.(*loggingStream).Read(0xd3a6708, {0x10cde80, 0x13928438})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/gopls/internal/protocol/log.go:32 +0x8c
golang.org/x/tools/internal/jsonrpc2.(*conn).run(0x26724330, {0x10cde80, 0x13928438}, 0xd746790)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/internal/jsonrpc2/conn.go:195 +0x74
created by golang.org/x/tools/internal/jsonrpc2.(*conn).Go in goroutine 56566
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/internal/jsonrpc2/conn.go:188 +0x80

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/diagnostics" && test == "TestValidImportCheck_GoPackagesDriver/default#01"

2025-02-28 20:28 x_tools-gotip-netbsd-arm tools@5f02a3e8 go@f4750a6c x/tools/gopls/internal/test/integration/diagnostics.TestValidImportCheck_GoPackagesDriver/default#01 [ABORT] (log)

=== RUN   TestValidImportCheck_GoPackagesDriver/default#01
    runner.go:238: context deadline exceeded
#### Start Gopls Test Logs for "TestValidImportCheck_GoPackagesDriver/default#01"
[Trace - 15:34:49.552 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"DRIVERTEST_RUN_AS_DRIVER":"1","GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"/home/swarming/.swarming/w/ir/x/t/go-build2550299547/b871/diagnostics.test","GOPATH":"/home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default#01/gopath","GOPROXY":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default#01/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3283568251/TestValidImportCheck_GoPackagesDriver/default%2301/work","name":"work"}]}


[Trace - 15:34:49.946 PM] Received response 'initialize - (1)' in 394ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel f4750a6cfb8ae84acee56cca1a51c886fa16cc32\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/diagnostics.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm\"},{\"Key\":\"GOOS\",\"Value\":\"netbsd\"},{\"Key\":\"GOARM\",\"Value\":\"7\"}],\"Version\":\"(devel)\"}"}}

...
panic: test timed out after 50m0s
	running tests:
		TestValidImportCheck_GoPackagesDriver (21s)
		TestValidImportCheck_GoPackagesDriver/default#01 (7s)

goroutine 56575 [running]:
testing.(*M).startAlarm.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2490 +0x3a4
created by time.goFunc
	/home/swarming/.swarming/w/ir/x/w/goroot/src/time/sleep.go:215 +0x2c
...
fmt.Fprintf({0x10c8ca0, 0x88a5310}, {0xdf327b, 0x18}, {0xbe15e80, 0x3, 0x3})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:226 +0x9c
golang.org/x/tools/gopls/internal/protocol.(*loggingStream).logCommon(0xd3a6708, {0x10c9180, 0x2679aa80}, 0x1)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/gopls/internal/protocol/log.go:117 +0x828
golang.org/x/tools/gopls/internal/protocol.(*loggingStream).Read(0xd3a6708, {0x10cde80, 0x13928438})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/gopls/internal/protocol/log.go:32 +0x8c
golang.org/x/tools/internal/jsonrpc2.(*conn).run(0x26724330, {0x10cde80, 0x13928438}, 0xd746790)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/internal/jsonrpc2/conn.go:195 +0x74
created by golang.org/x/tools/internal/jsonrpc2.(*conn).Go in goroutine 56566
	/home/swarming/.swarming/w/ir/x/w/targetrepo3821813473/internal/jsonrpc2/conn.go:188 +0x80

— watchflakes

[adonovan]

More netbsd-arm breakage. The builder is always spuriously broken and we have learned to ignore it, so it provides no signal, only cost without benefit. I propose that we turn down this builder.

@golang/netbsd

[bsiegert]

Sorry for the noise.

The builder is fairly unstable at the moment. I think that's due to hardware issues. Newer ARM SBCs often don't even run in 32 but mode any more.

I propose that we stop testing sub repositories (including x/tools) on the netbsd-arm builder but keep it around for the main repo for now.

[gopherbot]

Change https://go.dev/cl/655575 mentions this issue: main.star: limit scope of slow netbsd-arm host to go, net, sys

[gopherbot]

Closed by merging CL 655575 (commit golang/build@d4217e5) to luci-config.