x/tools/gopls: "diagnostic location is not among files of package: %s" assertion is unjustified for Diagnostic.Related #70791
Description
#!stacks
"bug.Errorf" && "cache.(*action).exec.func2:+48"
Issue created by stacks.
if mapper == nil {
// The start position was not among the package's parsed
// Go files, indicating that the analyzer added new files
// to the FileSet.
//
// For example, the cgocall analyzer re-parses and
// type-checks some of the files in a special environment;
// and asmdecl and other low-level runtime analyzers call
// ReadFile to parse non-Go files.
// (This is a supported feature, documented at go/analysis.)
//
// In principle these files could be:
//
// - OtherFiles (non-Go files such as asm).
// However, we set Pass.OtherFiles=[] because
// gopls won't service "diagnose" requests
// for non-Go files, so there's no point
// reporting diagnostics in them.
//
// - IgnoredFiles (files tagged for other configs).
// However, we set Pass.IgnoredFiles=[] because,
// in most cases, zero-config gopls should create
// another view that covers these files.
//
// - Referents of //line directives, as in cgo packages.
// The file names in this case are not known a priori.
// gopls generally tries to avoid honoring line directives,
// but analyzers such as cgocall may honor them.
//
// In short, it's unclear how this can be reached
// other than due to an analyzer bug.
return protocol.Location{}, bug.Errorf("diagnostic location is not among files of package: %s", tokFile.Name())
}The analyzer that reported the diagnostic is staticcheck's SA4023, but all its calls to Report look fine.
This stack dlmz3w was reported by telemetry:
gopls/buggolang.org/x/tools/gopls/internal/util/bug.report:+35golang.org/x/tools/gopls/internal/util/bug.Errorf:+2golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+48golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+22golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1honnef.co/go/tools/analysis/report.Report:+40honnef.co/go/tools/staticcheck/sa4023.run:+100golang.org/x/tools/gopls/internal/cache.(*action).exec.func7:+31golang.org/x/tools/gopls/internal/cache.(*action).exec:+277golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2sync.(*Once).doSlow:+5sync.(*Once).Do:=67golang.org/x/tools/gopls/internal/cache.execActions.func1:+2runtime.goexit:+0
golang.org/x/tools/[email protected] go1.23.2 linux/amd64 vscode (1)
Dups: ARI9LQ xuqd0A UM4FBg