x/tools/gopls: OutgoingCalls mishandles dynamic function calls

[adonovan]

Observe that the "outgoing calls" view shows edges from the site of the call f(). (The target of the call appears to be a node equivalent to the enclosing node for Foo, which is just wrong; the target of the call is obviously unknown.) OutgoingCalls should not report dynamic calls.

Notice too that the order in which outgoing calls are listed appears to be nondeterministic.

[gabyhelp]

Similar Issues

• x/tools/gopls: include function literals as outgoing callhierarchy calls #43438

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/663916 mentions this issue: gopls/internal/golang: CallHierarchy: show only *types.Func callees