cmd/compile: cannot convert uint to uintptr

[dvyukov]

cmd/compile fails on the following correct program:

package b

var (
    w []*uint
    x = *w[0]
    y = x
    z = (uintptr)(y)
)

./go.go:7: cannot use x (type uint) as type uintptr in assignment

gotype eats it.

go version devel +25a28da Sun Nov 15 23:41:28 2015 +0000 linux/amd64

Found with GoSmith (https://github.com/dvyukov/gosmith).

[griesemer]

This is unrelated to the new parser; the same error appears with the old parser:
go tool compile -oldparser foo.go

[mdempsky]

Slightly simpler repro:

package b

var (
    x uint
    y = x
    z = uintptr(y)
)

The problem is when staticassign is looking at the "z = uintptr(y)" node, it strips the OCONVNOP, finds the ONAME node for y, and then calls staticcopy(z, y, out).

staticcopy(z, y, out) reaches the case ONAME, recursively calls staticcopy(z, x, out) which returns false (because x's Defn is nil), and then synthesizes a "z = x" assignment, which later fails typechecking.

One fix seems to be to reinsert OCONVNOP nodes as necessary when generating that OAS node.

[odeke-em]

This bug no longer seems to be an issue on Go1.6.2 at least. See https://play.golang.org/p/4GCc3_5qoT

or inlined

package main

import (
    "fmt"
    "runtime"
)

func f1() {
    var (
        w []*uint
        x = *w[0]
        y = x
        z = (uintptr)(y)
    )
    fmt.Printf("z: %v\n", z)
}

func f2() {
    var (
        x uint
        y = x
        z = uintptr(y)
    )
    fmt.Printf("z: %v\n", z)
}

func main() {
    fmt.Printf("Version: %s\n", runtime.Version())
}

[griesemer]

Still an issue with 1.7.

[odeke-em]

@griesemer I am running Version: devel +7e45516 Sat Nov 26 05:01:32 2016 +0000 and the test program in #13263 (comment) compiles alright. Would you mind double checking?

[odeke-em]

Actually you are right(I stand corrected): with @dvyukov's test program with the global declarations it fails to compile but when I put them in functions, it compiles correctly.