-
Notifications
You must be signed in to change notification settings - Fork 89
feature: rebasing and working on LDAP commands #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bupd <[email protected]>
This command allows to ping the ldap server from the cli Signed-off-by: bupd <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=========================================
- Coverage 10.99% 6.70% -4.29%
=========================================
Files 173 258 +85
Lines 8671 15379 +6708
=========================================
+ Hits 953 1031 +78
- Misses 7612 14241 +6629
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces LDAP commands to the Harbor CLI, enabling administrators to manage and import LDAP users directly through the command line interface. The implementation builds on the existing configuration framework to provide seamless integration with Harbor's LDAP settings.
- Adds new LDAP API handlers for user search, server ping, user import, and group search operations
- Implements three CLI commands:
ldap ping
,ldap search
, andldap import
for LDAP server management - Updates documentation with comprehensive man pages and CLI documentation for all new LDAP commands
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
pkg/api/ldap_handler.go | New API handlers for LDAP operations including user search, server ping, user import, and group search |
cmd/harbor/root/ldap/*.go | CLI command implementations for ldap ping, search, and import subcommands |
cmd/harbor/root/cmd.go | Integration of LDAP commands into the main CLI structure |
doc/ | Documentation updates including man pages and CLI docs for all new LDAP commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Nucleo Fusion <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Nucleo Fusion <[email protected]>
Summary
This PR introduces LDAP commands to the CLI, enhancing Harbor's capabilities by allowing the management and import of LDAP users directly through the command line interface.
The addition of LDAP commands follows the recent integration of configuration commands #114 into the CLI. The configuration commands provide a foundational framework that allows administrators to set and manage Harbor configurations from the command line. By building on this foundation, the LDAP commands leverage the existing configuration setup, ensuring that user management aligns seamlessly with the configured LDAP settings.
Added Commands:
Conclusion:
This enhancement significantly improves the operational efficiency and capabilities of Harbor's CLI. It makes LDAP user management more accessible, quicker, and more integrated.