Skip to content

Conversation

iamdharmesh
Copy link
Collaborator

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR updates the generate-zip workflow file to use the 10up/action-wordpress-plugin-build-zip action. This action generates the ZIP file in the same way as the WordPress.org Plugin Deploy Action. Using this action provides peace of mind, knowing that we’ve tested exactly what will be deployed.

Closes #33

Steps to test the changes in this Pull Request:

Make sure that E2E tests GitHub action on this PR is passing.

Changelog entry

Dev - Run E2E tests on the zip generated by "Build release zip" action.

@iamdharmesh iamdharmesh self-assigned this Jun 4, 2025
@iamdharmesh
Copy link
Collaborator Author

@dkotter It seems 10up/action-wordpress-plugin-build-zip action is not allowed to use on this repo and we might need to add it as allowed action in the list. Could you please help with check on this?

Log: https://github.com/gocardless/woocommerce-gateway-gocardless/actions/runs/15442769475

cc: @vikrampm1

@dkotter
Copy link
Collaborator

dkotter commented Jun 6, 2025

@dkotter It seems 10up/action-wordpress-plugin-build-zip action is not allowed to use on this repo and we might need to add it as allowed action in the list. Could you please help with check on this?

@doomholderz Wondering if this is something you can help us with again, as I know you helped allow these initially (see #23 (comment))

@jeffpaul jeffpaul added this to the 3.0.0 milestone Jun 17, 2025
@vikrampm1 vikrampm1 modified the milestones: 3.0.0, 3.0.1 Jun 27, 2025
@jeffpaul
Copy link
Collaborator

dkotter
dkotter previously approved these changes Aug 13, 2025
@dkotter dkotter marked this pull request as ready for review August 13, 2025 16:54
@dkotter dkotter modified the milestones: 3.0.0, 2.9.8 Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run E2E tests on the zip generated by "Build release zip" action.
4 participants