Skip to content

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Feb 26, 2021

Follow-up for #5226 (comment). This pull request updates the .qhelp files only used in include by the other languages to use the extension .inc.qhelp as well.

====================

To reuse content between different help topics, you can store shared content in one query help file and then include it in a number of other query help files using the ``include`` element. The shared content can be stored either in the same directory as the including files, or in ``SEMMLE_DIST/docs/include``.
When a query help file is only included by other help files but does not belong to a specific query, it should have the file extension ``.inc.qhelp``.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to include this? Any feedback is appreciated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not on the documentation team, but this looks good to me 👍

@Marcono1234 Marcono1234 force-pushed the marcono1234/included-qhelp-files branch from 178c61d to 5a8ffa5 Compare March 4, 2021 21:05
@Marcono1234 Marcono1234 marked this pull request as ready for review March 4, 2021 21:07
@Marcono1234 Marcono1234 requested review from a team as code owners March 4, 2021 21:07
@aschackmull
Copy link
Contributor

Looks like csharp/ql/src/experimental/Security Features/Serialization/DefiningPotentiallyUnsafeXmlSerialization also needs a rename.

@Marcono1234
Copy link
Contributor Author

Ah right, though that file appears to be unused (#5274, unless I am overlooking something); should I simply delete it instead?

@aschackmull
Copy link
Contributor

Ah right, though that file appears to be unused (#5274, unless I am overlooking something); should I simply delete it instead?

@hvitved What do you say? Delete it?

@hvitved
Copy link
Contributor

hvitved commented Mar 8, 2021

@hvitved What do you say? Delete it?

It should actually be renamed to DefiningPotentiallyUnsafeXmlSerializer.qhelp to match the name of the query.

@aschackmull aschackmull merged commit aeb1314 into github:main Mar 8, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/included-qhelp-files branch March 8, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants