Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 25, 2025

Follow-up to #3154 to skip running npm install when running in a GitHub Actions workflow.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from esbena September 25, 2025 19:26
@mbg mbg requested a review from a team as a code owner September 25, 2025 19:26
@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 19:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This change modifies the check-node-modules.sh script to skip running npm install when executing in a GitHub Actions workflow environment, addressing potential issues with dependency installation in CI environments.

  • Adds a check for the GITHUB_ACTIONS environment variable to exit early when running in CI
  • Improves logging to provide clear feedback about npm install decisions
  • Maintains existing logic for local development environments

@mbg mbg merged commit 94a9b7a into main Sep 25, 2025
233 checks passed
@mbg mbg deleted the mbg/node/no-install-in-actions branch September 25, 2025 21:47
@github-actions github-actions bot mentioned this pull request Sep 26, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants