Skip to content

Fix: overwrite leftover ffmpeg temp file if a prior conversion failed #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix: overwrite leftover ffmpeg temp file if a prior conversion failed #2431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0079740
Remove possible leftover ffmpeg temp file from a previous failed conv…
gilbertgong Sep 25, 2024
f38b228
Revert "Remove possible leftover ffmpeg temp file from a previous fai…
gilbertgong Sep 26, 2024
3f469b2
Flag to force ffmpeg to overwrite output file if it exists
gilbertgong Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ void check_ffmpeg_availibility() {
bool convert_to_wav(const std::string & temp_filename, std::string & error_resp) {
std::ostringstream cmd_stream;
std::string converted_filename_temp = temp_filename + "_temp.wav";
cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1";
cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -y -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1";
std::string cmd = cmd_stream.str();

int status = std::system(cmd.c_str());
Expand Down