Added libsdl2-dev for container builds. #2424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building talk-llama seems to fail here as there is no sdl.h.
ggerganov
approved these changes
Sep 20, 2024
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* Added libsdl2-dev for SDL samples Building talk-llama seems to fail here as there is no sdl.h. * Adding libsdl2-dev for sdl.h * Adding libsdl2-dev for sdl.h
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* Added libsdl2-dev for SDL samples Building talk-llama seems to fail here as there is no sdl.h. * Adding libsdl2-dev for sdl.h * Adding libsdl2-dev for sdl.h
lyapple2008
pushed a commit
to lyapple2008/whisper.cpp.mars
that referenced
this pull request
Nov 2, 2024
* Added libsdl2-dev for SDL samples Building talk-llama seems to fail here as there is no sdl.h. * Adding libsdl2-dev for sdl.h * Adding libsdl2-dev for sdl.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to build cuda containers for talk-llama and it's erroring out on missing sdl.h. This is in the
libsdl2-devpackage.