Skip to content

Conversation

jart
Copy link
Contributor

@jart jart commented Aug 17, 2024

This change updates the -pc flag, so that a new xterm256 color scheme is used. This color scheme is believed to be better for three reasons:

  1. It should be friendlier to the colorblind. The scheme was designed by Paul Tol (see: https://personal.sron.nl/~pault/). TensorBoard uses it since 2017, so it's already popular in the machine learning community

  2. It should appear to be the same colors as before to people who aren't i.e. it's still a red-green spectrum like before but lightly modified

  3. It is readable in both white and black background terminals. The neon colors before were probably a bit too intense for white backgrounds.

Before

image

After

image

This change updates the -pc flag, so that a new xterm256 color scheme is
used. This color scheme is believed to be better for three reasons:

1. It should be friendlier to the colorblind. The scheme was designed by
   Paul Tol (see: https://personal.sron.nl/~pault/). TensorBoard uses it
   since 2017, so it's already popular in the machine learning community

2. It should appear to be the same colors as before to people who aren't
   i.e. it's still a red-green spectrum like before but lightly modified

3. It is readable in both white and black background terminals. The neon
   colors before were probably a bit too intense for white backgrounds.
jart added a commit to Mozilla-Ocho/llamafile that referenced this pull request Aug 18, 2024
This change updates the -pc flag, so that a new xterm256 color scheme is
used. This color scheme is believed to be better for three reasons:

1. It should be friendlier to the colorblind. The scheme was designed by
   Paul Tol (see: https://personal.sron.nl/~pault/). TensorBoard uses it
   since 2017, so it's already popular in the machine learning community

2. It should appear to be the same colors as before to people who aren't
   i.e. it's still a red-green spectrum like before but lightly modified

3. It is readable in both white and black background terminals. The neon
   colors before were probably a bit too intense for white backgrounds.

This change was upstreamed in ggml-org/whisper.cpp#2360
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ggerganov ggerganov merged commit 7f78675 into ggml-org:master Aug 20, 2024
@espinielli
Copy link

Great contribution...a great help for me personally...I can now SEE!

@jart
Copy link
Contributor Author

jart commented Aug 20, 2024

I'm so happy to hear that @espinielli!

bygreencn added a commit to bygreencn/whisper.cpp that referenced this pull request Sep 3, 2024
* ggerganov/master:
  sync : ggml vulkan (ggml/0)
  yolo : add backend support (ggml/924)
  ggml : fix typo in ggml-quants.c comment (ggml/922)
  feat: add new `sin` and `cos` operators (ggml/919)
  readme : fix broken links (ggml-org#2358)
  examples : use colorblind friendly TTY color scheme (ggml-org#2360)
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
This change updates the -pc flag, so that a new xterm256 color scheme is
used. This color scheme is believed to be better for three reasons:

1. It should be friendlier to the colorblind. The scheme was designed by
   Paul Tol (see: https://personal.sron.nl/~pault/). TensorBoard uses it
   since 2017, so it's already popular in the machine learning community

2. It should appear to be the same colors as before to people who aren't
   i.e. it's still a red-green spectrum like before but lightly modified

3. It is readable in both white and black background terminals. The neon
   colors before were probably a bit too intense for white backgrounds.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
This change updates the -pc flag, so that a new xterm256 color scheme is
used. This color scheme is believed to be better for three reasons:

1. It should be friendlier to the colorblind. The scheme was designed by
   Paul Tol (see: https://personal.sron.nl/~pault/). TensorBoard uses it
   since 2017, so it's already popular in the machine learning community

2. It should appear to be the same colors as before to people who aren't
   i.e. it's still a red-green spectrum like before but lightly modified

3. It is readable in both white and black background terminals. The neon
   colors before were probably a bit too intense for white backgrounds.
ldfrancis pushed a commit to ldfrancis/whisper.cpp that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants