Skip to content

Conversation

mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented Aug 1, 2024

This is also a bit of refactoring, but also would like to give users the option of adding some authorship data via model card metadata rather than via metadata override. However since Huggingface doesn't have one to one mapping, will need to add different style of ways people may want to enter such metadata organically.

@github-actions github-actions bot added the python python script changes label Aug 1, 2024
@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix python python script changes and removed python python script changes labels Aug 1, 2024
@mofosyne mofosyne force-pushed the add-more-metadata-from-model-card branch from 27eda07 to 74746ae Compare August 3, 2024 14:46
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems good overall, but I did not test it yet.

If you've tested that it works correctly in all relevant cases, feel free to merge.

@mofosyne mofosyne merged commit 1ef14b3 into ggml-org:master Aug 5, 2024
@mofosyne mofosyne deleted the add-more-metadata-from-model-card branch August 5, 2024 11:15
@mofosyne
Copy link
Collaborator Author

mofosyne commented Aug 5, 2024

Had a final lookover and at least we still got the basic test cases testing that area so should be ok.

I did identify future room for improvement in that I can see people wanting to put more specific information besides an array of string IDs for base_model and datasets (e.g. name, org, version, url, etc...). But let's wait and see if people use it enough to complain about it. Since we can always add detection for dicts, when the demand arrives.

arthw pushed a commit to arthw/llama.cpp that referenced this pull request Aug 7, 2024
* py: add more authorship metadata from model card

* fixup! py: add more authorship metadata from model card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants