ggml : make sure dst in ggml_set_rows gets a backend buffer #16319
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, too slow, nvm. :) |
ggerganov
reviewed
Sep 28, 2025
| result->op = GGML_OP_SET_ROWS; | ||
| result->src[0] = b; | ||
| result->src[1] = c; | ||
| result->src[2] = a; // make sure a gets a backend buffer |
There was a problem hiding this comment.
The reason it ends up without a buffer is because you applied ggml_set_rows on a tensor that is not used by any other operation in the graph. And since the ggml_set_rows is also missing the dependency due to this bug, in the end nothing in the graph depends on this tensor and the allocator correctly decides to not allocate it.
github-actions
bot
added
the
ggml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if you meant this as a definitive fix, or if there's some other logic that needs to be added?