Skip to content

ci: update vulkan ci #16294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

ci: update vulkan ci #16294

merged 1 commit into from
Oct 2, 2025
+27 −6

Conversation

netrunnereve
Copy link
Collaborator

The Ubuntu Vulkan SDK package is being discontinued, so I switched that to the generic one. I also made a couple changes to make it run faster (new llvmpipe and FP32 tests as that's easier for the CPU to run).

@netrunnereve netrunnereve requested a review from CISC as a code owner September 27, 2025 21:52
@github-actions github-actions bot added the devops improvements to build systems and github actions label Sep 27, 2025
@CISC CISC requested a review from 0cc4m September 28, 2025 08:38
CISC
CISC approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cache the SDK similarly to #15887

@netrunnereve
Copy link
Collaborator Author

Ok this should do it. Turns out it only saves like 30 seconds of runtime.

@CISC
Copy link
Collaborator

CISC commented Oct 1, 2025

Ok this should do it. Turns out it only saves like 30 seconds of runtime.

It will mainly prevent spamming external sources, and avoiding outages etc.

CISC
CISC reviewed Oct 1, 2025
View reviewed changes
@netrunnereve netrunnereve marked this pull request as draft October 2, 2025 00:55
@github-actions github-actions bot added documentation Improvements or additions to documentation build Compilation issues script Script related testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs Vulkan Issues specific to the Vulkan backend examples python python script changes server ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) OpenCL Issues specific to the OpenCL backend labels Oct 2, 2025
@netrunnereve netrunnereve removed the request for review from ggerganov October 2, 2025 01:00
@netrunnereve netrunnereve removed documentation Improvements or additions to documentation build Compilation issues script Script related testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs Vulkan Issues specific to the Vulkan backend examples python python script changes server ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) OpenCL Issues specific to the OpenCL backend labels Oct 2, 2025
@netrunnereve netrunnereve marked this pull request as ready for review October 2, 2025 01:03
@ggerganov
Copy link
Member

Good to merge?

@0cc4m 0cc4m merged commit f09aefa into ggml-org:master Oct 2, 2025
54 of 57 checks passed
@netrunnereve netrunnereve deleted the vulkan_ci branch October 2, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CISC CISC CISC approved these changes

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netrunnereve @CISC @ggerganov @0cc4m