Skip to content

Conversation

DamonFool
Copy link
Contributor

make causal-verify-logits fails if model names containing "." like Qwen2.5-0.5B-Instruct.

export MODEL_PATH=~/share/Qwen2.5-0.5B-Instruct
make causal-verify-logits

The following is the error msg.

Logits saved to data/llamacpp-Qwen2.5-0.5B-Instruct.bin
Logits saved to data/llamacpp-Qwen2.5-0.5B-Instruct.txt
ggml_metal_free: deallocating
Error: PyTorch logits file not found: data/pytorch-Qwen2.5-0.bin
Please run scripts/run-org-model.sh first to generate this file.
make: *** [causal-verify-logits] Error 1

It should be data/pytorch-Qwen2.5-0.5B-Instruct.bin instead of data/pytorch-Qwen2.5-0.bin.

I suggest just using os.path.basename(model_path) to fix it assuming that the model_path should be a dir path.

@DamonFool DamonFool requested a review from danbev as a code owner September 24, 2025 07:29
@github-actions github-actions bot added examples python python script changes labels Sep 24, 2025
@danbev danbev merged commit 63b54c8 into ggml-org:master Sep 24, 2025
1 check passed
@danbev
Copy link
Member

danbev commented Sep 24, 2025

@DamonFool Thanks again!

@DamonFool
Copy link
Contributor Author

@danbev Thanks again too.

@DamonFool DamonFool deleted the model-conversion branch September 24, 2025 08:32
pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request Sep 25, 2025
struct pushed a commit to struct/llama.cpp that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants