model-conversion : make causal-verify-logits fails with model names containing "." #16215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make causal-verify-logits
fails if model names containing "." likeQwen2.5-0.5B-Instruct
.The following is the error msg.
It should be
data/pytorch-Qwen2.5-0.5B-Instruct.bin
instead ofdata/pytorch-Qwen2.5-0.bin
.I suggest just using
os.path.basename(model_path)
to fix it assuming that themodel_path
should be a dir path.