minor: root cause in error message if loading backend library fails #16172
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
ericcurtin
approved these changes
Sep 22, 2025
|
Since @ericcurtin does not have possibility to merge this change anymore, who has ? @slaren ? |
danbev
approved these changes
Sep 29, 2025
rlewczuk
force-pushed
the
rle/ggml-ld-error-msgs
branch
from
830daaa to
5bc6480
Compare
|
I wonder if we rebase this code and push will the build go green @rlewczuk ? It would be useful to know who has merge rights also. I'm going to be less active reviewing PRs these days. If I could ask people to avoid tagging me, that would be good, because best I can do is tag someone else. I will continue to contribute where appropriate. |
rlewczuk
force-pushed
the
rle/ggml-ld-error-msgs
branch
from
5bc6480 to
2322195
Compare
|
Did it right now, albeit it was also rebased today morning (CET). Let's see if CI still fails. Are other PRs also showing similar errors ? Edit: seems to be tests flapping due to SVE changes, see #16314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional information to an error message when loading backend library via
ld_load_library()fails. This helps spotting why backend library did not load (missing library, missing dependency or unresolved symbol etc.).