vulkan: vec dot matrix multiplication fix #16151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd k in combination with batching
github-actions
bot
added
testing
jeffbolznv
approved these changes
Sep 21, 2025
|
Just confirming it here too: this indeed seems to have fixed leejet/stable-diffusion.cpp#847 . Thanks! |
|
@ggerganov Could you please sync ggml? |
struct
pushed a commit
to struct/llama.cpp
that referenced
this pull request
Sep 26, 2025
* vulkan: fix matrix multiplication index calculation for odd m/n and odd k in combination with batching * add odd m/n + odd k test with batching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with index calculations for specific matrix multiplications introduced in #16056. It should fix leejet/stable-diffusion.cpp#847.