Skip to content

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov commented Sep 19, 2025

A few changes to the contributing guidelines regarding the roles and responsibilities of the developers. The goals are to:

  • Improve the decision process about code maintenance and review responsibilities
  • Clarify requirements for new code
  • Strengthen the security of the project by limiting the amount of people with write access

After we merge this, the Github role of most existing collaborators will be updated from "Write" to "Triage". Only the core maintainers of the project will continue to have the "Write" role in the repository.

@ericcurtin
Copy link
Collaborator

One thing I think could be worth considering is to encourage a minimum of 2 codeowners if at all possible in any given area.

Avoids the problem of single points of failure, people going awol and generally reduces the load for any given maintainer.

Only tangentially related, but recommend enabling one or two AI code review bots like sourcery-ai and gemini-code-assist, have been used with great success on RamaLama and now Docker Model Runner projects.

Updated pull request guidelines for contributors and collaborators, and clarified merging practices for maintainers.
@ggerganov ggerganov merged commit 5c6106a into master Sep 22, 2025
3 checks passed
@ggerganov ggerganov deleted the contrib-update branch September 22, 2025 07:58
@ggerganov
Copy link
Member Author

Hm, apparently codeowners require to have write access to the repository: https://github.com/orgs/community/discussions/23042

I was quite sure that this is not required, since we can request PR reviews from "Triage" collaborators.

We can keep adding collaborators to the CODEOWNERS, but unfortunately they won't get auto-notified for PR reviews. Hopefully Github will fix this soon.

struct pushed a commit to struct/llama.cpp that referenced this pull request Sep 26, 2025
* contrib : update roles

* contrib : merge PR sections + add link to CI instructions

Updated pull request guidelines for contributors and collaborators, and clarified merging practices for maintainers.
@netrunnereve
Copy link
Collaborator

Is there a way to tell if someone's a maintainer? Right now both maintainers and Collaborators (Triage) have the collaborator sticker next to their name.

@ggerganov
Copy link
Member Author

@netrunnereve Unfortunately the Github UI does not present this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants