Remove HashMaps from wgpu API
#7133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Feb 14, 2025
CHANGELOG.md
Outdated
|
|
||
| ### Major Changes | ||
|
|
||
| #### Hashmaps Removed from Apis |
There was a problem hiding this comment.
typo:
Suggested change
| #### Hashmaps Removed from Apis | |
| #### Hashmaps Removed from APIs |
ErichDonGubler
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM, minus some nits and other things raised by @DJMcNab. Conditionally approving based on these getting addressed.
cwfitzgerald
changed the title
wgpu API
davnotdev
pushed a commit
to davnotdev/wgpu
that referenced
this pull request
Mar 4, 2025
* Remove HashMaps from Surface API * Fix Comments and Errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7019
This changes the surface apis over to arrays of key-value pairs.