Skip to content

Add filtering in layers #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Aug 20, 2024
Merged

Add filtering in layers #92

merged 40 commits into from
Aug 20, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Aug 9, 2024 •
edited
Loading

Adds filtering to Vector Tile and GeoJSON layers.

filters_both

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/filters

@gjmooney gjmooney added the enhancement New feature or request label Aug 20, 2024
@gjmooney gjmooney marked this pull request as ready for review August 20, 2024 07:57
martinRenou
martinRenou requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat! Thanks

packages/base/src/tools.ts
}

const json = await response.json();
tileUrl = json.tiles[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that for later us and open an issue for this, but there may be cases when there are multiple tiles urls, and we'll probably need to handle that case here.

@martinRenou
Copy link
Member

Another thing for a subsequent PR, we should expose filters to the Python API as well

@martinRenou
Copy link
Member

When testing a bit more this branch, it seems the buildings.jGIS file does not show up properly anymore:

Before:
Screenshot from 2024-08-20 11-54-39

After:
Screenshot from 2024-08-20 11-55-40

@gjmooney
Copy link
Collaborator Author

When testing a bit more this branch, it seems the buildings.jGIS file does not show up properly anymore:

That's probably because https://github.com/QuantStack/jupytergis/blob/83544ca3254f43eec777c9f3d9863b465a8a66cd/packages/base/src/mainview/mainview.tsx#L193 is using the url param and not tiles. The changes in #91 should resolve that.

gjmooney added 21 commits August 20, 2024 12:35
@gjmooney gjmooney requested a review from martinRenou August 20, 2024 10:56
martinRenou
martinRenou approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@martinRenou martinRenou merged commit a384117 into geojupyter:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou