Identify panel: try to infer the feature name instead of showing the default "Feature X" name #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martinRenou
commented
Aug 27, 2025
| for (const key of Object.keys(feature)) { | ||
| const lowerCase = key.toLowerCase(); | ||
|
|
||
| if ((lowerCase.includes('name') || lowerCase === 'id') && feature[key]) { |
There was a problem hiding this comment.
We'll have to see if this is a good rule on the long run.
There was a problem hiding this comment.
This is good for now but yeah we can expand it to using a list with generic names such as ['name', 'title', 'label', 'id', 'fid', 'identifier']
arjxn-py
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
This is looking good as a improvement 💯
Thanks @martinRenou :)
|
Integration tests report: appsharing.space |
mfisher87
pushed a commit
to mapninja/jupytergis-docwork
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
📚 Documentation preview: https://jupytergis--906.org.readthedocs.build/en/906/
💡 JupyterLite preview: https://jupytergis--906.org.readthedocs.build/en/906/lite