Automatically switch to identify panel when identifying #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Integration tests report: appsharing.space |
arjxn-py
commented
Aug 26, 2025
|
This works once for me, but not a 2nd time. Also, the first time, when it does switch tabs, there's a longer delay than expected! I think the new model attribute isn't being updated when I change tabs by manually clicking on a tab. |
martinRenou
force-pushed
the
identify-auto
branch
from
adaa076 to
d58999a
Compare
arjxn-py
commented
Aug 27, 2025
| annotationModel?: IAnnotationModel; | ||
|
|
||
| // TODO Add more modes: "annotating" | ||
| currentMode: 'panning' | 'identifying'; |
Comment on lines
+762
to
+767
| if (this._currentMode === 'identifying') { | ||
| this._currentMode = 'panning'; | ||
| } else { | ||
| this._currentMode = 'identifying'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you think we can have something more extensible for future:
setIdentifyMode(enabled: boolean): void {
this.currentMode = enabled ? 'identifying' : 'panning';
}
toggleIdentify(): void {
this.setIdentifyMode(this._currentMode !== 'identifying');
}
There was a problem hiding this comment.
I'm not sure, we can always work on it in the future :)
Screen.Recording.2025-08-27.at.17.17.54.mp4Works really well, you rock @martinRenou |
mfisher87
pushed a commit
to mapninja/jupytergis-docwork
that referenced
this pull request
Aug 28, 2025
* Automatically switch to identify panel when identifying * Introduce model.currentMode + activate tab everytime the identified features change --------- Co-authored-by: martinRenou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--900.org.readthedocs.build/en/900/
💡 JupyterLite preview: https://jupytergis--900.org.readthedocs.build/en/900/lite