Avoid react-fontawesome 3.0.0 for now because of breaking change #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3.0.0 was released today, and now check-release CI is failing. ``` Cannot find module '@fortawesome/react-fontawesome' or its corresponding type declarations. ``` This change should get things working again.
mfisher87
force-pushed
the
avoid-react-fontawesome-breaking-change
branch
from
8d75b5f to
6ce0e0f
Compare
|
Integration tests report: appsharing.space |
mfisher87
changed the title
arjxn-py
approved these changes
Aug 23, 2025
mfisher87
added a commit
to mapninja/jupytergis-docwork
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3.0.0 was released today, and now check-release CI is failing.
This change should get things working again.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--888.org.readthedocs.build/en/888/
💡 JupyterLite preview: https://jupytergis--888.org.readthedocs.build/en/888/lite