-
Notifications
You must be signed in to change notification settings - Fork 58
Support Graduated, Categorised & Canonical Symbology on VectorTiles #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration tests report: appsharing.space |
--------- Co-authored-by: Greg Mooney <[email protected]>
packages/base/src/dialogs/symbology/vector_layer/VectorRendering.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjxn-py and I discussed on a call today that perhaps we should not remove stroke color from graduated/categorical vector symbology. I think it's OK if we do; we can bring it back later based on how it impacts user. If we do remove stroke, we should remove the stroke color and fill color inputs from the graduated/categorical vector symbology dialogs.
Co-authored-by: Greg Mooney <[email protected]> Co-authored-by: Matt Fisher <[email protected]>
📚 Documentation preview: https://jupytergis--844.org.readthedocs.build/en/844/
💡 JupyterLite preview: https://jupytergis--844.org.readthedocs.build/en/844/lite