Restore follow mode #812
Restore follow mode #812
Conversation
The idea is that we'd pass in a custom icon renderer function to the UsersItem component. Our custom function is based on the old code prior to [PR geojupyter#723](geojupyter#723). I really don't know what I'm doing here. ToolbarWidget isn't a react component, so I don't know how to manage state! Perhaps we don't need to keep track of state at all, we just need to update the model and let the model keep track of it. Co-authored-by: Arjun Verma <[email protected]>
|
|
|
cc @brichet any thoughts on how to manage state when passing in a custom icon renderer, as this class is not a react component? I'm confused :) |
|
I shall be going to push a couple of commits on this branch maybe tomorrow to fix it, I hope you don't mind @mfisher87 :) |
|
Absolutely don't mind at all! Thanks, Arjun :) Did you figure out how to handle the state management? |
Thanks. Yes, I moved the state management out of the component state to the custom |
|
That makes sense! Great call :D |
|
Integration tests report: appsharing.space |
Description
Arjun and I paired on this a bit this morning!
Resolves #811
The idea is that we'd pass in a custom icon renderer function to the UsersItem component which would handle click-to-follow behavior. Our custom function is based on the old code prior to PR #723.
I really don't know what I'm doing here 🙃
ToolbarWidgetisn't a react component, so I don't know how to manage state! Perhaps we don't need to keep track of state at all, we just need to update the model and let the model keep track of it. But then, how do we display the red outline around the selected user?Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--812.org.readthedocs.build/en/812/
💡 JupyterLite preview: https://jupytergis--812.org.readthedocs.build/en/812/lite