Skip to content

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Jul 6, 2025

Description

Ports jupytercad/JupyterCAD#737

75730

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--800.org.readthedocs.build/en/800/
💡 JupyterLite preview: https://jupytergis--800.org.readthedocs.build/en/800/lite

Copy link
Contributor

github-actions bot commented Jul 6, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/new-jgis-file

@arjxn-py arjxn-py added the enhancement New feature or request label Jul 6, 2025
Copy link
Contributor

github-actions bot commented Jul 6, 2025

Integration tests report: appsharing.space

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope, great idea! What do you think about using "Project" instead of "File", e.g. "New JupyterGIS Project"?

@arjxn-py
Copy link
Member Author

arjxn-py commented Jul 6, 2025

Thanks for the review, Matt :)

Dope, great idea! What do you think about using "Project" instead of "File", e.g. "New JupyterGIS Project"?

I have no strong opinion on this "File" is to keep the uniformity between jupytercad & jupytergis, but to me "Project" sounds good too

@arjxn-py
Copy link
Member Author

arjxn-py commented Jul 7, 2025

Let's do "Project" as Qgis does the same.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit e68609d into geojupyter:main Jul 7, 2025
14 checks passed
@mfisher87 mfisher87 changed the title Add 'New JupyterGIS file' option to context menu Add 'New JupyterGIS Project' option to context menu Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants