Skip to content

New file fix #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

New file fix #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c3560
Fix issue with new file
gjmooney Jul 29, 2024
0bb493d
Add test for file creation
gjmooney Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/jupytergis_core/src/jgisplugin/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const activate = (
format: 'text',
size: undefined,
content:
'{\n\t"layers": {},\n\t"sources": {},\n\t"options": {"latitude": 0, "longitude": 0, "zoom": 0, "bearing": 0, "pitch": 0},\n\t"layerTree": []\n\t"terrain": {}\n}'
'{\n\t"layers": {},\n\t"sources": {},\n\t"options": {"latitude": 0, "longitude": 0, "zoom": 0, "bearing": 0, "pitch": 0},\n\t"layerTree": [],\n\t"terrain": {"source": "", "exaggeration": 0}\n}'
});

// Open the newly created file with the 'Editor'
Expand Down
24 changes: 24 additions & 0 deletions ui-tests/tests/new-file.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { expect, test } from '@jupyterlab/galata';

test.describe('#newFile', () => {
test.afterEach(async ({ page }) => {
await page.activity.closeAll();
});

test('New file should open with no errors', async ({ page }) => {
await page
.getByLabel('notebook content')
.getByText('New JGIS File')
.click();

const tab = page.getByLabel('notebook content');
const sources = page.getByText('Sources', { exact: true });
const layers = page.getByText('Layers');
const map = page.getByLabel('Map');

await expect(tab).toBeVisible();
await expect(sources).toBeVisible();
await expect(layers).toBeVisible();
await expect(map).toBeVisible();
});
});