Skip to content

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Jun 12, 2025

Copy link
Contributor

Binder 👈 Launch a Binder on branch HaudinFlorence/jupytergis/propose_some_renaming_suggestions

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call! I think "scene" could be a term we re-use later, for example a scene could be a bounding box and a set of enabled layers within a project, and maybe you save multiple scenes to enable users to quickly make many changes to the map view with one click. "Scenes" could be the mechanism that enables storytelling in future versions.

I'd really love to have a glossary that we can use to educate users about terms we use in the UI as well as keep us consistent in our internal naming.

@mfisher87
Copy link
Member

Wat is going on with the checks 😲

@mfisher87
Copy link
Member

Ah, an incident, that's wat

https://www.githubstatus.com/incidents/d9xd9k1j6sl0

@mfisher87 mfisher87 changed the title Propose some renaming suggestions Rename generateScene() -> generateMap() Jun 12, 2025
@HaudinFlorence
Copy link
Contributor Author

@mfisher87 @martinRenou Feel free to suggest other renames that you would find relevant

@mfisher87
Copy link
Member

I think there are lots of opportunities for naming improvements. I'll keep my eyes open :)

Copy link
Contributor

Integration tests report: appsharing.space

@mfisher87 mfisher87 merged commit b426bb1 into geojupyter:main Jun 12, 2025
30 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants