-
Notifications
You must be signed in to change notification settings - Fork 59
GEODES STAC API Search #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration tests report: appsharing.space |
33532fc
to
75d32d6
Compare
769def8
to
42461fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I only tested it briefly for now, will dive deeper into the code later.
isLoading: boolean; | ||
} | ||
|
||
const API_URL = 'https://geodes-portal.cnes.fr/api/stac/search'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for a future PR, we should think of making this user-provided. Maybe an input
element in the UI to provide your endpoint for the STAC API. Or a setting.
We should also provide a way to add some API token if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we could have a drop down in the UI to select which endpoint to use, or an option in the settings would be good too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to set a specific endpoint is very important in my view. I don't think it must be in this PR, but perhaps we could have a dropdown with many options from stacindex.org pre-populated for users who might not already have an endpoint in mind, but allow them to fallback to a custom endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this locally, I'm getting CORS failures and so results always shows as 0. My proxy URL is set by default to corsproxy.io; what might I be missing?
Perhaps we could add an error indicator to the UI when the requests are failing.
I'm not sure how I feel about the STAC browser being in the sidebar. Layers are always added by dialogs and I think we should go for consistency. Do you think it would be reasonable to move it into the layer browser dialog in this PR, or should that be separate? Or should we consider a completely separate dialog?
isLoading: boolean; | ||
} | ||
|
||
const API_URL = 'https://geodes-portal.cnes.fr/api/stac/search'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to set a specific endpoint is very important in my view. I don't think it must be in this PR, but perhaps we could have a dropdown with many options from stacindex.org pre-populated for users who might not already have an endpoint in mind, but allow them to fallback to a custom endpoint.
👍🏽 we had the exact same discussion with Greg yesterday. Greg is looking into adding such dropdown.
I have the same. It works well in plain jupyterlab, but fails for the jupyterlite deployment. |
(This all only applies to Lab) Just for the record, because of how the So if you're getting 0 results something else is happening. Did you select a start time? I have it defaulted to the start of yesterday, which might be too recent. |
Totally agreed. Instead of looping of the URLs and trying them all, I feel we should:
|
Hmm... yes, I tried to mimic the exact settings from your video recording! I'll try again today :) |
GEODES is down for maintenance until the 26th so you won't get any results today either 🙃 |
One working API (not down today) one can try https://openveda.cloud/api/stac/search |
72ea9be
to
71966c3
Compare
Since new commits are still coming through, could we convert to draft until it's stable for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/questions
7b851d5
to
49a1b8b
Compare
49a1b8b
to
26ccb54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!! 💯 🥇
Description
This adds a STAC browser implementing the GEODES API.
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--753.org.readthedocs.build/en/753/
💡 JupyterLite preview: https://jupytergis--753.org.readthedocs.build/en/753/lite