Skip to content

Processing: Bounding boxes of a vector layer(#734) #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Processing: Bounding boxes of a vector layer(#734) #744

merged 2 commits into from
Jun 9, 2025

Conversation

Gauss-Taylor-Euler
Copy link
Contributor

@Gauss-Taylor-Euler Gauss-Taylor-Euler commented Jun 9, 2025 •
edited
Loading

Processing: Bounding boxes of a vector layer(#734)

Add processing for centroids , addressing #734, also change the label and description of centroids .

boundingBoxes_demo.mp4

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Binder 👈 Launch a Binder on branch Gauss-Taylor-Euler/jupytergis/process_bounding_boxes

@arjxn-py arjxn-py added the enhancement New feature or request label Jun 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025 •
edited
Loading

Integration tests report: appsharing.space

arjxn-py
arjxn-py approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks really good.

Maybe we should also look for a way to disable both centroids and bounding box processing commands for point vector geometry layer as these options are not relevant for those cases. It's not in the scope of this PR, Let's keep it as a separate issue.

@arjxn-py arjxn-py mentioned this pull request Jun 9, 2025
Closed
martinRenou
martinRenou approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mfisher87
Copy link
Member

Maybe we should also look for a way to disable both centroids and bounding box processing commands for point vector geometry layer as these options are not relevant for those cases. It's not in the scope of this PR, Let's keep it as a separate issue.

💯

@mfisher87 mfisher87 mentioned this pull request Jun 9, 2025
Open
mfisher87
mfisher87 approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@mfisher87 mfisher87 merged commit 111db43 into geojupyter:main Jun 9, 2025
14 checks passed
elifsu-simula pushed a commit to elifsu-simula/jupytergis that referenced this pull request Jun 12, 2025
@Gauss-Taylor-Euler @elifsu-simula
Processing: Bounding boxes of a vector layer(geojupyter#734) (geojup…
e2d915f 
…yter#744)

* Processing: Bounding boxes of a vector layer(geojupyter#734)

* Change Bounding Boxes and Centroids labels to correspond to qgis naming convention
@arjxn-py arjxn-py mentioned this pull request Jul 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjxn-py arjxn-py arjxn-py approved these changes

@mfisher87 mfisher87 mfisher87 approved these changes

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauss-Taylor-Euler @mfisher87 @martinRenou @arjxn-py